Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure that -h works for all commands. fixes #506 #507

Merged
merged 1 commit into from
Sep 29, 2021
Merged

fix: ensure that -h works for all commands. fixes #506 #507

merged 1 commit into from
Sep 29, 2021

Conversation

justinedelson
Copy link
Member

@justinedelson justinedelson commented Sep 29, 2021 •
edited
Loading

Description

Add a hook to intercept cases where -h is passed to commands to ensure consistent behavior

Related Issue

#507

Motivation and Context

Inconsistency between strict and non-strict commands is weird -- strict isn't really something users should think about.

How Has This Been Tested?

  • Unit tests
  • Manual tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Sep 29, 2021 •
edited
Loading

Codecov Report

Merging #507 (ef6907f) into main (e19842f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #507   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           70        71    +1     
  Lines         1561      1570    +9     
  Branches       180       183    +3     
=========================================
+ Hits          1561      1570    +9
Impacted Files Coverage Δ
src/hooks/prerun/help-override.js 100.00% <100.00%> (ø)
src/hooks/prerun/prerun-all.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e19842f...ef6907f. Read the comment docs.

@jasonrpoteet
Copy link

I created this issue of Oclif to look into the base issue with -h not being supported. oclif/command#256

@justinedelson justinedelson marked this pull request as ready for review September 29, 2021 19:23
@justinedelson
Copy link
Member Author

cool. although I've been waiting for oclif to review/merge oclif/parser#163 for a while, so I think we should workaround this (since unlike that issue this one is pretty non-invasive to address)

@justinedelson justinedelson merged commit cf62ba7 into main Sep 29, 2021
github-actions bot pushed a commit that referenced this pull request Sep 29, 2021
@semantic-release-bot
chore(release): 2.18.3 [skip ci]
a5d4885 
## [2.18.3](2.18.2...2.18.3) (2021-09-29)

### Bug Fixes

* ensure that -h works for all commands. fixes [#506](#506) ([#507](#507)) ([cf62ba7](cf62ba7))
@github-actions
Copy link

🎉 This PR is included in version 2.18.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinedelson @jasonrpoteet