Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move array srings to json #87

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

jesusfcr
Copy link
Contributor

Moves json arrays encoded as strings to actual yaml arrays for those values:

api.conf.saml.trustedDomains
api.conf.defaultOwners
crontinuous.conf.teamsWhitelistScan
crontinuous.conf.teamsWhitelistReport
reportsgenerator.conf.ses.cc
scanengine.conf.queues.other[].checktypes

In this example all three expressions generates the same string

a: '["a","b"]'     # Previous
a: ["a","b"]       # New formats
a: [a,b]
a:
  - a
  - b

It provides compatibility with previous format to facilitate the transition, but will be dropped in future releases

Copy link
Contributor

@danfaizer danfaizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jesusfcr jesusfcr marked this pull request as draft March 11, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants