Skip to content
This repository has been archived by the owner on Oct 21, 2024. It is now read-only.

Use inputstream.adaptive for playback #25

Merged
merged 1 commit into from
Apr 20, 2020
Merged

Conversation

michaelarnauts
Copy link
Collaborator

@michaelarnauts michaelarnauts commented Apr 20, 2020

Playback streams with Inputstream Adaptive.

Based on 8d229d4 from @mediaminister

Helps #4

@michaelarnauts michaelarnauts merged commit 121ea88 into master Apr 20, 2020
@michaelarnauts michaelarnauts deleted the inputstream branch April 20, 2020 14:26
@dagwieers dagwieers added the enhancement New feature or request label Apr 20, 2020
@dagwieers
Copy link
Collaborator

Don't we want to make this a setting so people (in the future) can enable/disable this?

The use-case here is that in the future maybe IA has a bug which breaks playback, or Kodi fixes the playback. Or in case of ARM, OMXplayer works well, but IA may not, etc.

@michaelarnauts
Copy link
Collaborator Author

I don't like to have settings without a known use case. It makes the add-on more complex. If we find a use case where it makes sense to disable this, we could add the setting or try to handle it automatically. For now, what I have tested, the results with Inputstream Adaptive are always better, and it is supported on all recent systems anyway.

I don't think there is a downside to using Inputstream Adaptive with OMXplayer?

@dagwieers
Copy link
Collaborator

dagwieers commented Apr 20, 2020

I understand wanting to keep things simple, but having options to keep things working helps in offering a "dependable" solution. Nothing hurts more than not being able to watch what you planned to watch.

The examples I gave were situations we may end up in. Given the fact that IA is updated in a whim without testing, and we have known issues, these are not far-fetched.

I haven't tested IA with OMXplayer yet, but I don't expect issues at this time (cannot forecast the future with IA). Neither would I have expected issues with VIER-VIJF-ZES- streams in general 😉 You decide.

@mediaminister
Copy link
Collaborator

In case of an emergency, you can always disable InputStream Adaptive in Kodi and HLS streams will still play.

@dagwieers
Copy link
Collaborator

@mediaminister True, but that also impacts other add-ons. So yeah, suboptimal depending on the exact playback issue.

@mediaminister
Copy link
Collaborator

I agree, InputStream Adaptive is not really needed to play HLS, so it makes sense to give the user a choice.

@michaelarnauts
Copy link
Collaborator Author

Sure, we can make it an option then in the settings where we turn on IA by default.

@michaelarnauts michaelarnauts added this to the v0.2.0 milestone Nov 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants