Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache results to avoid multiple version calculations for the same inputs #547

Closed
wants to merge 1 commit into from

Conversation

adamralph
Copy link
Owner

No description provided.

@adamralph adamralph added the enhancement New feature or request label Jun 17, 2021
@adamralph
Copy link
Owner Author

@bording I thought I'd take a look a this, with reference to this comment that you pointed out to me, but it looks like MSBuild.UseResultsCache has been deprecated and now "does nothing", so I guess I'd have to implement this caching myself.

@adamralph
Copy link
Owner Author

FTR there's also CallTarget.UseResultsCache, but it has also been deprecated and "does nothing".

@bording
Copy link
Collaborator

bording commented Jun 17, 2021

@bording I thought I'd take a look a this, with reference to this comment that you pointed out to me, but it looks like MSBuild.UseResultsCache has been deprecated and now "does nothing", so I guess I'd have to implement this caching myself.

Looking through the MSBuild codebase, it does seem to confirm that UseResultsCache is just a stub in the public API now, so that approach does appear to be a dead end.

The RegisterTaskObject/GetRegisteredTaskObject looks like it would still work, but I believe you'd have to be running the versioning logic from an MSBuild task to use those.

Assuming you aren't interested in introducing an MSBuild task assembly, then it does seem like you'd have to build your own caching logic. It seems like it would need to be some sort of disk-based results file.

@adamralph
Copy link
Owner Author

Thanks for the input @bording. I'm going to close this as a wontfix. FWIW I had another look at #112 and I still don't think there is enough ROI on switching to an MSBuild task, even taking this feature into consideration.

@adamralph adamralph closed this Jun 18, 2021
@adamralph adamralph deleted the cache-results branch June 18, 2021 17:34
@adamralph adamralph added the wontfix This will not be worked on label Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants