-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSBuild caching #1021
MSBuild caching #1021
Conversation
12c7d0f
to
e20f3e7
Compare
e20f3e7
to
13751cd
Compare
FWIW, I tested this with https://github.com/Particular/ServiceControl, and a single threaded build went from 43 seconds to 24 seconds. |
testing the water with dotnet/msbuild#10418 |
13751cd
to
885e264
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I still prefer moving all the logic to an MSBuild task instead of calling other processes during the build, but this seems like an okay intermediate step.
b420f31
to
808898e
Compare
@bording I've released this in 5.1.0-rc.1—please feel free to give it a try. |
re-released as 6.0.0-rc.1 because the next release contains at least one breaking change |
With this change, the version is calculated once (per thread used by the SDK) and then cached.
For solutions with many projects, this can significantly reduce build time.