AirLift menu option so arbitrary boards can declare they have an airlift board attached #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adafruit SAMD board support tweaks to add arduino menu to select that the board has an attached airlift board. Picks built-in vs airlift shield, vs airlift featherwing, vs airlift bitsy based on which main board is selected. sets nina pins accordingly. Also sets HAS_ADAFRUIT_AIRLIFT flag, so the adafruit fork of arduinoble can also just work.
This is meant to make it easier to build a script for a board connected to an airlift, particularly when the script needs to span several cpp files, and you need the precompiler defines to be visible from all the compilation units. Hard coding a change to the boards file works, but gets overwritten the next time the core gets upgraded, and means all other scripts for the same board get those same settings. Forking the boards file for one project gets annoying.
Anyway, this is a suggestion, feel free to disregard if it doesn't help everyone else.
Jeremy Williams