Adding chain support on V2 protocol #113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
Actually, celery-node considers that the chain returned in embed.chain is always
nullWhat is the new behavior (if this is a feature change)?
The goal was to implement the chain process in the celery-node library to fit our need for celery.chain with remote tasks (tasks that are not on the same server as the client, here Django). We were inspired by the Python code (celery/app/trace.trace_task) to implement the Worker.createTaskHandler function.
When launching the task, if it succeeds, we check if the received message has a chain. If it does, we call the sendChainTask method.
In the method, we extract the last item from the chain (the next task to be executed) and store it in a variable children. Then, we create a client (which will publish the task to the broker), using the queue defined in children. We create the message according to the Celery protocol V2. Finally, we push the message to the broker with client.sendTaskMessage.