feat: better logging #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for disworse ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bassiounix
reviewed
Oct 21, 2024
There was a problem hiding this comment.
This is not the place of configs. A separate config module is required.
There was a problem hiding this comment.
@bassiounix This is a feature request, we can create a separate issue for this.
The intention of this PR is to add logging, not create a config module.
bassiounix
reviewed
Oct 21, 2024
| BaseContext, | ||
| GraphQLRequestContext, | ||
| GraphQLRequestContextWillSendResponse, | ||
| GraphQLRequestListener, |
There was a problem hiding this comment.
Unused import
Suggested change
| GraphQLRequestListener, | |
| Remove `GraphQLRequestListener` |
bassiounix
reviewed
Oct 21, 2024
| export class ApolloLogger implements ApolloServerPlugin { | ||
| private readonly logger = new Logger("GraphQL"); | ||
|
|
||
| async requestDidStart(requestContext: GraphQLRequestContext<BaseContext>) { |
There was a problem hiding this comment.
Mark full access specifier as the logger
Suggested change
| async requestDidStart(requestContext: GraphQLRequestContext<BaseContext>) { | |
| public async requestDidStart(requestContext: GraphQLRequestContext<BaseContext>) { |
bassiounix
reviewed
Oct 21, 2024
| @@ -26,7 +30,10 @@ export class TransactionInterceptor implements NestInterceptor { | |||
| const gqlContext = GqlExecutionContext.create(context); | |||
| const ctx = gqlContext.getContext(); | |||
|
|
|||
| const db = drizzle(this.pool, { schema }); | |||
| const db = drizzle(this.pool, { | |||
There was a problem hiding this comment.
Why the db is not injected?
There was a problem hiding this comment.
Ya 3ammena, separate issue wallah 😭 See #2
bassiounix
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be needed by #57.