Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix background layout to inherit from parent #72

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

Balstun
Copy link
Contributor

@Balstun Balstun commented Feb 3, 2022

Setting the Layout window to be 100% of the viewport results in a partially white background. The Layout has been modified to inherit its boundaries from its parents, as to circumvent this issue.

@Balstun Balstun requested a review from a team as a code owner February 3, 2022 02:24
@vercel
Copy link

vercel bot commented Feb 3, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/acmutd/portal/6QVisqHoPCYAjfbUbZ6mGxRVJ7Q2
✅ Preview: https://portal-git-hotfix-application-styles-acmutd.vercel.app

@Balstun
Copy link
Contributor Author

Balstun commented Feb 3, 2022

Setting the Layout to height: 100% appears to result in a similar white background problem for desktop devices. Apparently, the viewport limitation for mobile is intentional, as described in this StackOverflow discussion.

To-Do:

  • Fix height of layout to be 100vh
  • Enforce different layout parameters for mobile views

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant