Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: team matching accept and join teams api #253

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

doanhtu07
Copy link
Contributor

@doanhtu07 doanhtu07 commented Mar 26, 2024

Summary

  1. Finish API for the poster to accept interests of multiple hackers' profiles
  2. Finish API for the hacker to accept/reject joining a team

NOTES

AWS SES

  1. The AWS SES setup is done. You will need to contact @DedsecKnight for access and secret keys.
  2. Add the keys to .env.local as follows:
AWS_SES_ACCESS_KEY=
AWS_SES_SECRET_KEY=
  1. The current from email address is [email protected], Mike will contact Purva and Salman for further adjustments.
  2. We can further make the email sending more beautiful by designing templates or something similar.

Design specs

  1. My API designs use user token from request headers instead of direct API input parameters for requester's information. Can someone check whether this is what should be done? Or does the team want direct API input instead?
  2. Do we also need to send emails to Hackers when the Poster accepts their interests?
  3. Do we allow Hackers to accept joining a team when the Hackers are marked as already in a team?

That's all for now. If there's anything else I need to change, please let me know.

@doanhtu07 doanhtu07 added the Type: Feature Request New feature or request label Mar 26, 2024
@doanhtu07 doanhtu07 self-assigned this Mar 26, 2024
@doanhtu07 doanhtu07 requested a review from a team as a code owner March 26, 2024 06:47
Copy link

vercel bot commented Mar 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hackportal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2024 8:12am

@doanhtu07 doanhtu07 changed the title Feat/team matching accept and join teams api feat: team matching accept and join teams api Mar 26, 2024
Update AWS SES keys and refine two APIs accept-interest and decide-join-team
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant