You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UPDATE: Added required changes. Currently, non check-in hackers are classified in Stats at a Glance as "Illegal Hacker" (because it is shorter than Non Check-in), but there are likely better name for this category.
Implemented feature to allow super admins to filter stats at a glance by user
permissions (only hackers, admin, etc).
BREAKING CHANGE: Changed configuration of GeneralStats data type and data
returned by /api/stats
resolves#115
"illegal hackers" includes admins and super admins, who usually don't check in anyways. We can drop that category completely, and add a "Checked in Hackers" filter to only get stats from hackers that have checked in to the event.
Currently, "Hacker" represents checked-in hackers (non check-in hackers are completely ignored in the backend). Unless I misunderstood the intention, I can rename the "Hacker" to "Checked-in Hacker" if necessary.
The issue with this PR is that we've switched to Nivo, so there's like hella conflicts uhhhhhhhhhhhhhhhhhh @DedsecKnight idk if you want to reimplement this in Nivo with a new PR or just fix the conflicts in this one (but the first might be easier)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented feature to allow super admins to filter stats at a glance by user
permissions (only hackers, admin, etc).
BREAKING CHANGE: Changed configuration of GeneralStats data type and data
returned by /api/stats
resolves #115
UPDATE: Added required changes. Currently, non check-in hackers are classified in Stats at a Glance as "Illegal Hacker" (because it is shorter than Non Check-in), but there are likely better name for this category.