Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added feature to filter stats at a glance by user type #122

Closed
wants to merge 18 commits into from

Conversation

DedsecKnight
Copy link
Member

@DedsecKnight DedsecKnight commented May 17, 2022

Implemented feature to allow super admins to filter stats at a glance by user
permissions (only hackers, admin, etc).

BREAKING CHANGE: Changed configuration of GeneralStats data type and data
returned by /api/stats

resolves #115

UPDATE: Added required changes. Currently, non check-in hackers are classified in Stats at a Glance as "Illegal Hacker" (because it is shorter than Non Check-in), but there are likely better name for this category.

Implemented feature to allow super admins to filter stats at a glance by user
permissions (only hackers, admin, etc).

BREAKING CHANGE: Changed configuration of GeneralStats data type and data
returned by /api/stats

resolves #115
@DedsecKnight DedsecKnight requested a review from a team as a code owner May 17, 2022 00:25
@vercel
Copy link

vercel bot commented May 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
hackportal ✅ Ready (Inspect) Visit Preview Oct 26, 2022 at 2:26AM (UTC)

nam-t24
nam-t24 previously approved these changes May 29, 2022
@abdullah50053
Copy link
Collaborator

abdullah50053 commented Jun 19, 2022

  • Add filter for "Checked in"

@abdullah50053
Copy link
Collaborator

abdullah50053 commented Jun 21, 2022

"illegal hackers" includes admins and super admins, who usually don't check in anyways. We can drop that category completely, and add a "Checked in Hackers" filter to only get stats from hackers that have checked in to the event.

@abdullah50053
Copy link
Collaborator

Add a "Checked in" option under "Filter Stats by"

@DedsecKnight
Copy link
Member Author

Currently, "Hacker" represents checked-in hackers (non check-in hackers are completely ignored in the backend). Unless I misunderstood the intention, I can rename the "Hacker" to "Checked-in Hacker" if necessary.

Copy link
Collaborator

@MichaelZhao21 MichaelZhao21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are things that need to be fixed in terms of code quality but it works; we'll fix it later

@MichaelZhao21
Copy link
Collaborator

The issue with this PR is that we've switched to Nivo, so there's like hella conflicts uhhhhhhhhhhhhhhhhhh @DedsecKnight idk if you want to reimplement this in Nivo with a new PR or just fix the conflicts in this one (but the first might be easier)

@MichaelZhao21
Copy link
Collaborator

Closing this issue due to the fact that we completely changed the library that was used for this PR and thus making hella merge conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add ability to include/exclude groups from stats
4 participants