-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[add] "solemodel_forest" #3
Conversation
…tion as npropositions, check and creating new function conjunctiveformulas
Better remove "solemodel_forest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change
src/SoleDecisionTreeInterface.jl
Outdated
@@ -79,4 +79,9 @@ function solemodel(tree::DT.Leaf; replace_classlabels = nothing, use_featurename | |||
return SoleModels.ConstantModel(prediction, info) | |||
end | |||
|
|||
function solemodel(model :: DecisionTree.Ensemble) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use "DT" here as to avoid the name clash.
There are errors still |
Mh, there are still test errors. Must investigate |
What about now? |
Small change to be able to use " solemodel " directly on tree forest models.