Merge remote-tracking branch 'origin/fix/linting' into dev

eslint.config.js

@@ -20,6 +20,7 @@ const config = [
 	{
 		rules: {
 			"vue/attributes-order": ["warn", { alphabetical: true }],
+			"no-undef": "off",
 		},
 	},
 ];

nuxt.config.ts

@@ -42,7 +42,7 @@ export default defineNuxtConfig({
 	},
 
 	pinia: {
-		// @ts-ignore
+		// @ts-expect-error somehow there is no types for this
 		autoImports: ["defineStore", "acceptHMRUpdate"],
 	},
 

playwright.config.ts

@@ -3,7 +3,7 @@
 import { defineConfig, devices } from "@playwright/test";
 
 const port = process.env.PORT ?? 3000;
-const baseUrl = `http://localhost:${port}`;
+const baseUrl = `http://localhost:${String(port)}`;
 
 export default defineConfig({
 	testDir: "./e2e",

src/components/CombinedMapChart.vue

@@ -85,7 +85,7 @@ function pointFormatter() {
 		// @ts-expect-error todo find out how to type this function correctly
 		.map((query) => [query.userInput, this[query.userInput], query.color])
 		.sort((a, b) => b[1] - a[1]);
-	// @ts-expect-error
+	// @ts-expect-error once again highcharts interal funciton, this is okay
 	return `<b>${this.id}</b><br/>
 ${queryArray
 	.map(

src/components/DataDisplay/DataDisplayCollocations.vue

@@ -139,23 +139,23 @@ function pointFormatter() {
 		this.name +
 		"</b><br/>" +
 		"Frequency: " +
-		// @ts-expect-error
+		// @ts-expect-error this is used inside the table rendering.
 		this.freq +
 		"<br/>" +
 		"Collocational Frequency: " +
-		// @ts-expect-error
+		// @ts-expect-error this is used inside the table rendering.
 		this.coll_freq +
 		"<br/>" +
 		"D: " +
-		// @ts-expect-error
+		// @ts-expect-error this is used inside the table rendering.
 		this.d +
 		"<br/>" +
 		"M: " +
-		// @ts-expect-error
+		// @ts-expect-error this is used inside the table rendering.
 		this.m +
 		"<br/>" +
 		"T: " +
-		// @ts-expect-error
+		// @ts-expect-error this is used inside the table rendering.
 		this.t
 	);
 }

src/components/DataDisplay/DataDisplayKeywordInContext.vue

@@ -51,10 +51,9 @@ const q = computed(() =>
 						date: Tbl_refs![1] ?? "",
 						source: Tbl_refs![4] ?? "",
 						region: Tbl_refs![2] ?? "",
-						// @ts-ignore wrong types in api lib
+						// @ts-expect-error wrong types in api lib
 						left: Left!.map(({ str, strc }) => str || strc).join(" "),
 						word: typeof Kwic![0] !== "undefined" ? Kwic![0].str : "",
-						// @ts-ignore wrong types in api lib
 						right: Right!.map(({ str }: { str: string }) => str).join(" "),
 						docid: Tbl_refs![0] ?? "",
 						topic: Tbl_refs![3] ?? "",

src/components/DataDisplay/DataDisplayMediaSource.vue

@@ -8,7 +8,7 @@ const t = useTranslations("Corpsum");
 const queryStore = useQueryStore();
 const { queries } = storeToRefs(queryStore);
 
-const mode = ref("relative");
+const mode: Ref<"absolute" | "relative"> = ref("relative");
 const expand = ref(false);
 
 const api = useApiClient();
@@ -105,7 +105,7 @@ const isStacked = computed(() => chartMode.value === "stack");
 
 			<template v-if="sourceDistributions && queries">
 				<MediaStackedBarChart
-					:mode="mode as 'absolute' | 'relative'"
+					:mode="mode"
 					:queries="queries"
 					:source-distributions="sourceDistributions"
 					:stack="isStacked"

src/components/DataDisplay/DataDisplaySourceTable.vue

@@ -16,7 +16,7 @@ const columns = computed(() => {
 		return {
 			accessorKey: key,
 			header: () => h("div", { class: "text-right" }, key),
-			// @ts-ignore this comes from tanstack-table
+			// @ts-expect-error this comes from tanstack-table
 			cell: ({ row }) => {
 				const value = row.getValue(key);
 				return h("div", { class: "text-right font-medium" }, value as string);

src/components/Media/MediaStackedBarChart.vue

@@ -33,7 +33,6 @@ const series = computed(() => {
 			}`,
 			data: categories.value
 				.map((category) => props.sourceDistributions[i]?.find(({ media }) => category === media))
-				// @ts-ignore
 				.map((a) => (a ? a[props.mode] : 0)),
 		};
 	});

src/components/Search/CorpusSelection.vue

@@ -23,7 +23,6 @@ const { data: subCorpora, isPending: subCorporaLoading } = useQuery({
 	queryKey: ["get-corp-info", selectedCorpus] as const,
 	queryFn: async () => {
 		const response = await api.search.getCorpInfo({
-			/** @ts-ignore undefined prevented through subCorpFetchingIsEnabled **/
 			corpname: selectedCorpus.value?.name,
 			subcorpora: 1,
 		});

src/components/Search/QueryItem.vue

@@ -16,7 +16,6 @@ const setFilters = computed(() => {
 		// @ts-expect-error just counts the set filters. if it is undefined that's falsy.
 		(key) => props.query.facettingValues[key]?.length || props.query.facettingValues[key]?.value,
 	);
-	keys;
 	return keys;
 });
 

src/plugins/highcharts.client.ts

@@ -17,6 +17,6 @@ export default defineNuxtPlugin((nuxtApp) => {
 
 	// overwrites the excel download to work propperly. this part is copied and adapted from a highcharts fiddle using that library. could be adapted to use a more maintained one, but would only recomend, if issues surface
 	HighchartsExcelDownload(Highcharts);
-	// @ts-ignore
+	// @ts-expect-error this works and is like in the documentation
 	nuxtApp.vueApp.use(HighchartsVue, { tagName: "HighCharts" });
 });

src/plugins/jsonViewer.ts

@@ -1,7 +1,7 @@
 import "vue-json-viewer/style.css";
 
 // esilint-ignore-next-line  @typescript-eslint/ban-ts-comment
-// @ts-ignore
+// @ts-expect-error sadly has no types
 import JsonViewer from "vue-json-viewer/ssr";
 
 export default defineNuxtPlugin((nuxtApp) => {

src/stores/corpora.ts

@@ -21,13 +21,11 @@ export const useCorporaStore = defineStore(
 
 		const corporaForSearch = computed(
 			() =>
-				`corpname=${selectedCorpus.value?.corpname}${
-					selectedSubCorpus.value ? `;usesubcorp=${selectedSubCorpus.value.n}` : ""
-				}`,
+				`corpname=${selectedCorpus.value?.corpname ?? ""}${selectedSubCorpus.value ? `;usesubcorp=${selectedSubCorpus.value.n}` : ""}`,
 		);
 
 		const corporaForSearchWithoutSubCorpus = computed(
-			() => `corpname=${selectedCorpus.value?.corpname}`,
+			() => `corpname=${selectedCorpus.value?.corpname ?? ""}`,
 		);
 
 		const corporaForSearchKeys = computed(() => {

src/stores/query.ts

@@ -29,7 +29,7 @@ export const useQueryStore = defineStore(
 
 			const concordance_query: Partial<ConcordanceQuery> = {};
 
-			// @ts-ignore
+			// @ts-expect-error this is okay, because we set the correct key
 			concordance_query[keyToKey[type]] = userInput;
 			concordance_query.queryselector = type;
 
@@ -90,14 +90,13 @@ export const useQueryStore = defineStore(
 		});
 
 		const getQueryWithFacetting = (query: CorpusQuery) => {
-			const result: Record<string, string> = { ...query.concordance_query };
+			const result: Record<string, string | Array<string>> = { ...query.concordance_query };
 			for (const key in query.facettingValues) {
 				const elem = query.facettingValues[key];
 				if (!elem) continue;
 				// console.log({ key, elem })
 				if (Array.isArray(elem)) {
 					if (!elem.length) continue;
-					// @ts-ignore
 					result[`sca_${key}`] = elem;
 				} else result[elem.key] = elem.value;
 			}

vitest.config.ts

@@ -1,7 +1,6 @@
 import { defineVitestConfig } from "@nuxt/test-utils/config";
 
 export default defineVitestConfig({
-	// @ts-ignore this is exactly as in the documentation
 	test: {
 		environment: "nuxt",
 		environmentOptions: {