[SDK-222] [no connection serial ] + implement missing internal presence map + presencequeue #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sacOO7
commented
Aug 14, 2023
sacOO7
commented
- Fixed RTP2, RTP17, RTP19: PresenceMap #255
sacOO7
force-pushed
the
fix/presencemap
branch
from
2bf1ca1
to
b5b390d
Compare
sacOO7
force-pushed
the
fix/presencemap
branch
from
b5b390d
to
ba8e1fc
Compare
github-actions
bot
temporarily deployed
to
staging/pull/621/features
sacOO7
force-pushed
the
fix/presencemap
branch
from
4ed4640
to
31b739a
Compare
github-actions
bot
temporarily deployed
to
staging/pull/621/features
github-actions
bot
temporarily deployed
to
staging/pull/621/features
sacOO7
force-pushed
the
fix/presencemap
branch
from
2740853
to
14252e8
Compare
github-actions
bot
temporarily deployed
to
staging/pull/621/features
github-actions
bot
temporarily deployed
to
staging/pull/621/features
github-actions
bot
temporarily deployed
to
staging/pull/621/features
sacOO7
force-pushed
the
fix/presencemap
branch
from
5d5660d
to
1b7a72d
Compare
github-actions
bot
temporarily deployed
to
staging/pull/621/features
sacOO7
changed the title
lmars
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
This looks ok from my perspective, but I defer to @SimonWoolf to review the changes he requested
|
@lmars merging this PR into integration-2.0, since one more review required for recovery spec related commits. I will re-raise @SimonWoolf comments there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.