-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ECO-4234] Updates Push Example to include Channels #1879
Conversation
Looks really cool, thanks @umair-ably
|
I think sending by |
The readme already covers this use-case using the Push Inspector. When running on a single device/simulator, push via client or device behave the same - you only really notice the difference if you had several simulators running. Could be something worth adding as a future improvement, but not a pressing improvement for the key things this example showcases imo |
|
Hey team , unless there is anything generally wrong this is a vast improvement on what we had before so lets work on this idea and get it landed. any further enhancements can be implemented as required |
I've created an issue for the error handling #1888 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Updated.Push.Example.mov