Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the displaying of errors in the AblyPushExample #1888

Open
maratal opened this issue Mar 13, 2024 · 4 comments
Open

Simplify the displaying of errors in the AblyPushExample #1888

maratal opened this issue Mar 13, 2024 · 4 comments
Labels
code-quality Affects the developer experience when working in our codebase.

Comments

@maratal
Copy link
Collaborator

maratal commented Mar 13, 2024

Now it shows alerts, but it makes the code very bulky. Should be something else, a text filed for example at the bottom of the window.

┆Issue is synchronized with this Jira Task by Unito

@lawrence-forooghian
Copy link
Collaborator

lawrence-forooghian commented Apr 22, 2024

Is this a code quality issue or a user experience issue? I’m not sure what you mean by "it makes the code very bulky".

@lawrence-forooghian lawrence-forooghian added the enhancement New feature or improved functionality. label Apr 22, 2024
@maratal
Copy link
Collaborator Author

maratal commented Apr 22, 2024

I've meant that you need a lot of lines of code to just show a simple alert (alert != 1 line of code in SwiftUI).

@lawrence-forooghian
Copy link
Collaborator

So it's code quality, not UX?

@maratal
Copy link
Collaborator Author

maratal commented Apr 22, 2024

Correct, code quality.

@lawrence-forooghian lawrence-forooghian added code-quality Affects the developer experience when working in our codebase. and removed enhancement New feature or improved functionality. labels Apr 22, 2024
@lawrence-forooghian lawrence-forooghian changed the title Improve error handling in the AblyPushExample Simplify the displaying of errors in the AblyPushExample Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality Affects the developer experience when working in our codebase.
Development

No branches or pull requests

2 participants