Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make opts accessable to mailer #49

Merged
merged 1 commit into from
Mar 3, 2024
Merged

Conversation

SethHorsley
Copy link
Contributor

closes #48

@codespearhead
Copy link

There's a failing test:

290 /opt/hostedtoolcache/Ruby/2.7.8/x64/lib/ruby/2.7.0/psych.rb:456:in
291 parse_stream': undefined method `parse' for #<Psych::Parser:0x0000555835987a28>

Can you install the following dependency and try again?

apt-get install -y libyaml-dev

@SethHorsley
Copy link
Contributor Author

SethHorsley commented Jan 17, 2024

I think if we rerun the failing tests it should work. Its working in main and i did not change anything that would effect libyaml.

@abevoelker abevoelker merged commit 5e0607f into abevoelker:master Mar 3, 2024
13 of 14 checks passed
@abevoelker
Copy link
Owner

Thanks for your contribution! 🎉 I merged this into master a long while ago, but only just released it with gem version 1.0.2. Took me a while to fix the build due to some family health issues - thanks for your patience

@SethHorsley
Copy link
Contributor Author

awesome. Ill update my gems to upstream thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass a different host or _url options to mailer magic_link_url
3 participants