Refactor #163
Closed
Refactor #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruv282
reviewed
Sep 2, 2024
| @@ -88,187 +55,21 @@ class _MyHomePageState extends State<MyHomePage> { | |||
| /// | |||
| late Future<List<Workout>> workouts; | |||
There was a problem hiding this comment.
Consider using a provider to manage the list of workouts globally.
dhruv282
reviewed
Sep 2, 2024
| @@ -79,7 +46,7 @@ class MyHomePage extends StatefulWidget { | |||
|
|
|||
| class _MyHomePageState extends State<MyHomePage> { | |||
There was a problem hiding this comment.
consider moving the home page component to a separate file for better readability.
dhruv282
reviewed
Sep 2, 2024
| import 'package:path_provider/path_provider.dart'; | ||
| import 'package:share_plus/share_plus.dart'; | ||
|
|
||
| class LocalFileUtil { |
There was a problem hiding this comment.
Good job moving the I/O interaction to a util class!!
dhruv282
reviewed
Sep 2, 2024
| behavior: SnackBarBehavior.fixed, | ||
| duration: Duration(seconds: 4), | ||
| showCloseIcon: true, | ||
| const errorDeletingWorkoutSnackBar = SnackBar( |
There was a problem hiding this comment.
Why not use the method below instead of this?
dhruv282
reviewed
Sep 2, 2024
| if (Platform.isWindows || Platform.isLinux) { | ||
| logger.d("Platform is Windows or Linu, using FFI database factory"); |
There was a problem hiding this comment.
typo
Suggested change
| logger.d("Platform is Windows or Linu, using FFI database factory"); | |
| logger.d("Platform is Windows or Linux, using FFI database factory"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.