-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes for tests #2195
base: master
Are you sure you want to change the base?
fixes for tests #2195
Conversation
- set requred version of pillow to 9.5.0 - test-ffmpeg-reader - change duration number to match video - ffmpeg-reader - add displaymatrix to be read as video rotation - config set binary to autodetect
@antonpetrov145 Thanks for the contribution! I'm not sure if removing |
Idk, maybe worth throwing your suggested fix into the discussion? |
Thank you for your time to look at the changes I made. The idea behind setting the ffmpeg binary to auto-detect by default and removing the test is because of an issue that was because of ffmpeg-imageio setting the default binary to exe even on Linux (my other PR) causing Path error on importing moviepy. #2189 #2190
Yes sure, is it ok for me to write there? |
@antonpetrov145 I've now had (more of) a look at the code (and related issues), though haven't been able to test it – am I understanding correctly that changing |
@keikoro made the change you proposed |
tests/
addresses issue Test suite fails for most Windows, Linux tests #2183