Replace 'tostring' by 'tobytes' in 'video.io.gif_writers::write_gif' #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't merge them because I was hesitant about the performance/memory impact of changing the yield into a return and I hadn't had time to properly investigate. I suspect that there's nothing that can be done about it. |
|
Could you consider this change separately? This breaks GIF creation in Python3.9 but the other deprecation even with latest Numpy can be ignored. |
|
Yes certainly. Feel free to merge this PR. |
|
This has fixed second warning of #1338. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
array.tostringwas deprecated in Python v3.2, being replaced byarray.tobytes, so I've just changed their name. This method it's removed in Python 3.9 (Release notes) and the change prevents next warning: