Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Jubjub to ECC stdlib #1282

Closed
wants to merge 199 commits into from
Closed

Add Jubjub to ECC stdlib #1282

wants to merge 199 commits into from

Conversation

alv-around
Copy link

@alv-around alv-around commented Feb 21, 2023 •
edited
Loading

Add jubjub to stdlib #1251

Features:

  • Proof-Of-Ownership
  • VerifyEddsa

Schaeff and others added 30 commits September 28, 2022 19:15
@Schaeff
add support for the pallas curve field
d90de5e
@Schaeff
add changelog
4db3a03
@Schaeff
implement nova example
11452ad
@Schaeff
implement cli command for toy nova computation in absence of serializ…
24f8b1c 
…ation
@Schaeff
fix issues
bcade1a
@Schaeff
remove bellperson from default as it does not compile to wasm
378bc14
@Schaeff
fix test, reset cache
111bd73
@Schaeff
regenerate lockfile, update wasm-pack
cd3502c
@Schaeff
use xl instance for js tasks
62b76f3
@Schaeff
add changelog
f991b76
@dark64
allow user-provided randomness in setup
0cdcedd
@dark64
fix tests
655a54c
@dark64
add changelog, update zokrates-js
4ac95c7
@dark64
clippy
ed9a0b5
@dark64
improve js tests
097e707
@dark64
move rng function to proof systems crate
43cb632
@dark64
remove cash restore
6de2fe9
@dark64
revert
ce04905
@dark64
enable js feature in test
3e8ada4
@dark64
merge develop, fix conflicts
8d9e889
@dark64
fix zir assembly propagation
3a54661
@Schaeff
Merge pull request Zokrates#1258 from Zokrates/fix-assembly-propagation
66b4ec3 
Fix zir assembly propagation
@rex4539
Fix typos
28ac409
@dark64
Merge pull request Zokrates#1260 from rex4539/typos
553da16 
Fix typos
@dark64
use ark parallel feature
2fa711e
@dark64
optimize js lib size, inline wasm
6ee546d
@dark64
add getrandom dependency
8d8972a
@dark64
fmt
b090888
@dark64
fix tests
b9d8965
@dark64
update book
e66b3c8
dark64 and others added 26 commits May 23, 2023 12:34
@dark64
Create 1317-dark64
862400e
@Schaeff
short circuit on constant branch conditions
5582b1f
@Schaeff
propagate embed call in reducer
066d353
@dark64
allow complex type assignee in witness assignment
2082157
@Schaeff
Merge pull request Zokrates#1313 from Zokrates/fix-constant-embed-red…
4529fa4 
…uction

Propagate embed call in reducer
@dark64
add missing alignment, changelog
4cc2f62
@only4sim
Fixed a small typo, the right bracket next to bitwidth was mistyped. (Z…
32f0f43 
…okrates#1312)

* Fixed a small typo, the right bracket next to bitwidth was mistyped.

* Update types.md

Change the '[' to ')'.
@Schaeff
Merge pull request Zokrates#1317 from Zokrates/dark64-patch-3
4307184 
Fix constant in mimc7
@Schaeff
Merge pull request Zokrates#1315 from Zokrates/compile-time-short-cir…
cd15f02 
…cuit

Short circuit on constant branch conditions
@dark64
check composite types, fix possible incorrect signature in zir function
948383d
@dark64
update changelog
f8f3c88
@dark64
add more tests
350430f
@dark64
suggestions, update book
b55ae6f
@dark64
remove extra space
2cde470
@dark64
detect division by zero in typed propagation
791a9b6
@dark64
add changelog
6b30372
@Schaeff
Merge pull request Zokrates#1318 from Zokrates/asm-complex-type-assig…
a4fc3fc 
…nment

Allow composite field type in witness assignment
@Schaeff
Merge pull request Zokrates#1326 from Zokrates/detect-div-by-zero
737b75f 
Detect division by zero in typed propagation
@alv-around
remove unnecessary macros
148a73c
@alv-around
jubjub signature verification
0129bbe
@alv-around
Merge branch 'develop' into jubjub
3f89d67
@alv-around
valid signature verification for low values
7283c4c
@alv-around
Revert "remove pragma macro from nonStrictUnpack256"
4121c84 
This reverts commit a741f9e.
@alv-around
jubjub proofOfOwnership and signature verification
b09c38e
@alv-around
nunStrictUnpack256 refactor to support 255-bits fields from bls12_381
b0daee2
@alv-around
stdlib ecc module refactor to facilitate the addition signatures from…
b7b4997 
… other curves
@alv-around alv-around marked this pull request as ready for review July 4, 2023 14:43
@alv-around
Copy link
Author

@dark64 @Schaeff. I finished the implementation for the Jubjub curve in the stdlib.

I had to re-arrange some stuff, because many ecc things were written for 254-bit values, and in the jubjub many are 255.

I also wrote in a way so in the future it is easy to integrate the signatures for bls12-377 and other Edwardstwisted curves

@alv-around alv-around changed the title Jubjub Add Jubjub to ECC stdlib Jul 5, 2023
@alv-around alv-around closed this Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alv-around @Schaeff @dark64 @rex4539 @Turupawn @only4sim