Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accounting tests #1032

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

Accounting tests #1032

wants to merge 29 commits into from

Conversation

jjcnn
Copy link
Contributor

@jjcnn jjcnn commented Jul 12, 2021

Tests of send and accept, and their effects on the sender's and recipient's balances.

The tests have been designed so that they ought to be easy to incorporate into the blockchain test suite, which is necessary to ensure the correct semantics.

@vaivaswatha has requested that this PR links to Zilliqa/scilla-rtl#46.

@jjcnn jjcnn marked this pull request as ready for review July 14, 2021 16:37
@jjcnn jjcnn mentioned this pull request Jul 14, 2021
vaivaswatha added a commit to Zilliqa/Zilliqa that referenced this pull request Aug 2, 2021
@jjcnn
Copy link
Contributor Author

jjcnn commented Oct 8, 2021

@vaivaswatha : What's the status on this? Did we solve the C++ side problems?

@vaivaswatha
Copy link
Contributor

@vaivaswatha : What's the status on this? Did we solve the C++ side problems?

@KaustubhShamshery

@jjcnn
Copy link
Contributor Author

jjcnn commented Nov 1, 2021

@KaustubhShamshery : Any news on the C++ side of the accounting issue?

@vaivaswatha
Copy link
Contributor

@jjcnn I just merged master to this branch. Can you confirm that it's all sane still?

@jjcnn
Copy link
Contributor Author

jjcnn commented Nov 24, 2021

@jjcnn I just merged master to this branch. Can you confirm that it's all sane still?

Everything still looks good. All tests pass, and the code from master doesn't seem to touch anything accounting-related.

@vaivaswatha
Copy link
Contributor

Additional accounting tests

@jjcnn AcceptAndCheckSenderBalance in the support contract doesn't take an expected_balance parameter, but this commit assumes so.

@jjcnn
Copy link
Contributor Author

jjcnn commented Jan 6, 2022

Additional accounting tests

@jjcnn AcceptAndCheckSenderBalance in the support contract doesn't take an expected_balance parameter, but this commit assumes so.

@vaivaswatha : Fixed.

I've also fixed the merge conflicts, so the branch should be in order again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants