add pub functionality for zaino #8964
Open
+116
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For Zaino to use Zebra as its backed it requires access to primitives held in Zebra-Chain and Zebra-RPC.
Solution
-Several structs in zebra-rpc were made pub and getter / setter functionality was added.
-From impl was added to ['ConsensusBranchId'] in zebra-chain.
Tests
The most complex functionality added is simple getter / setter impls, I believe that adding new tests for this would be inefficient / redundant.
Follow-up Work
Due to patched libraries in Zebra:main causing issues in Zaino these changes were made atop v1.9.0, once the patches are removed we will update the zebra version to 2.0.0, there is a chance that additional changes will be required for changes in zebra v2.0.0.
PR Author's Checklist
PR Reviewer's Checklist