Address Str4d’s comments on #171 #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notably, `HashType` has changed incompatibly, so ZcashFoundation/zebra#8751 will need to be updated.
sellout
force-pushed
the
post-hoc-code-review
branch
from
1fde7fd
to
e748f2f
Compare
str4d
suggested changes
Sep 30, 2024
Co-authored-by: Jack Grigg <[email protected]>
sellout
force-pushed
the
post-hoc-code-review
branch
from
0b2098f
to
b7bdbc9
Compare
7 tasks
conradoplg
approved these changes
Oct 24, 2024
conradoplg
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notably,
HashTypehas changed incompatibly, soZcashFoundation/zebra#8751 will need to be updated.