Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow identifying culprit in error returned by dkg::part3() #728

Merged
merged 3 commits into from
Nov 4, 2024
Merged

allow identifying culprit in error returned by dkg::part3() #728

merged 3 commits into from
Nov 4, 2024

Conversation

conradoplg
Copy link
Contributor

Closes #725

@StackOverflowExcept1on
Copy link
Contributor

StackOverflowExcept1on commented Sep 25, 2024 •
edited
Loading

I think it would also be useful to split part3 function into several parts. For example, one part takes max_signers, identifier, round1_packages, round2_packages. This way, some independent party (like a smart contract) can find culprit, and other participants can locally calculate their secret shares.

Also, an independent party can probably compute PublicKeyPackage since it only requires an identifier and a commitment (VerifiableSecretSharingCommitment). It would be nice to have such an API.

@mpguerra mpguerra mentioned this pull request Oct 8, 2024
Open
@conradoplg conradoplg mentioned this pull request Oct 15, 2024
Open
natalieesk
natalieesk approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@natalieesk natalieesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

mergify bot added a commit that referenced this pull request Nov 4, 2024
@mergify
Merge of #728
df41d1a
@mergify mergify bot mentioned this pull request Nov 4, 2024
Closed
7 tasks
@mergify mergify bot merged commit 9a4394c into main Nov 4, 2024
19 checks passed
@mergify mergify bot deleted the invalid-secret-share-culprit branch November 4, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natalieesk natalieesk natalieesk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Returns culprit for Error::InvalidSecretShare
3 participants
@conradoplg @StackOverflowExcept1on @natalieesk