Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add refreshing shares image for book #710

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add refreshing shares image for book #710

wants to merge 1 commit into from

Conversation

natalieesk
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

Visit the preview URL for this PR (updated for commit 9d2bddf):

https://frost-book--pr710-refreshing-shares-im-rmrzybwq.web.app

(expires Tue, 06 Aug 2024 11:43:11 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b7f43333fbf8fa5527ab3f0dd7bd10bb1fa7401c

conradoplg
conradoplg requested changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Would you mind changing calculate_refresh_shares() in the figure to compute_refresh_shares()?

Also I think it would be helpful to include the old KeyPackage in the figure as an input to refresh_share()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conradoplg conradoplg conradoplg requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@natalieesk natalieesk

Labels
None yet
Projects
FROST
Status: Review/QA
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@natalieesk @conradoplg