-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add computing PublicKeyPackage from commitments #551
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #551 +/- ##
==========================================
+ Coverage 81.76% 81.94% +0.17%
==========================================
Files 30 30
Lines 3082 3151 +69
==========================================
+ Hits 2520 2582 +62
- Misses 562 569 +7
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed comment
Last Rust also introduced some clippy issues so I went ahead and fixed them here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Allow computing PublicKeyPackage from commitments.
It also refactors a lot of related code which makes everything more organized.
Expanded from #502, I made a mess with the history after syncing with main and didn't want to force push in the contributor's PR.