Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add computing PublicKeyPackage from commitments #551

Merged
merged 21 commits into from
Oct 27, 2023

Conversation

conradoplg
Copy link
Contributor

Allow computing PublicKeyPackage from commitments.

It also refactors a lot of related code which makes everything more organized.

Expanded from #502, I made a mess with the history after syncing with main and didn't want to force push in the contributor's PR.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (c0c57f4) 81.76% compared to head (c42f022) 81.94%.
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #551      +/-   ##
==========================================
+ Coverage   81.76%   81.94%   +0.17%     
==========================================
  Files          30       30              
  Lines        3082     3151      +69     
==========================================
+ Hits         2520     2582      +62     
- Misses        562      569       +7     
Files Coverage Δ
frost-core/src/batch.rs 100.00% <100.00%> (ø)
frost-core/src/frost.rs 92.44% <100.00%> (+0.08%) ⬆️
frost-core/src/frost/identifier.rs 98.64% <100.00%> (-0.12%) ⬇️
frost-core/src/frost/round2.rs 100.00% <100.00%> (ø)
frost-core/src/lib.rs 85.16% <100.00%> (ø)
frost-core/src/signing_key.rs 84.31% <100.00%> (ø)
frost-core/src/verifying_key.rs 98.52% <100.00%> (+0.34%) ⬆️
frost-core/src/frost/keys/dkg.rs 87.64% <95.52%> (-1.50%) ⬇️
frost-core/src/frost/keys.rs 97.75% <94.52%> (-0.66%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed comment

@conradoplg
Copy link
Contributor Author

Last Rust also introduced some clippy issues so I went ahead and fixed them here.

Copy link
Contributor

@natalieesk natalieesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mergify mergify bot merged commit 71c0925 into main Oct 27, 2023
15 checks passed
@mergify mergify bot deleted the pubkey-package-from-commitments branch October 27, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants