Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve sign() performance by caching SigningCommitments #493

Merged
merged 1 commit into from
Sep 2, 2023

Conversation

conradoplg
Copy link
Contributor

Closes #454

Benchmark:

FROST Signing ristretto255/Round 2/2
                        time:   [97.239 µs 97.456 µs 97.727 µs]
                        change: [-28.248% -28.139% -28.010%] (p = 0.00 < 0.05)
                        Performance has improved.
FROST Signing ristretto255/Round 2/7
                        time:   [180.00 µs 181.16 µs 182.72 µs]
                        change: [-19.124% -18.843% -18.525%] (p = 0.00 < 0.05)
                        Performance has improved.
FROST Signing ristretto255/Round 2/67
                        time:   [1.1946 ms 1.1955 ms 1.1966 ms]
                        change: [-3.4950% -3.2638% -3.0433%] (p = 0.00 < 0.05)
                        Performance has improved.
FROST Signing ristretto255/Round 2/667
                        time:   [11.588 ms 11.607 ms 11.629 ms]
                        change: [-1.4843% -1.2623% -1.0580%] (p = 0.00 < 0.05)
                        Performance has improved.

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch coverage: 93.33% and project coverage change: -0.13% ⚠️

Comparison is base (60d9942) 77.46% compared to head (eb6fa70) 77.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #493      +/-   ##
==========================================
- Coverage   77.46%   77.34%   -0.13%     
==========================================
  Files          30       30              
  Lines        2738     2741       +3     
==========================================
- Hits         2121     2120       -1     
- Misses        617      621       +4     
Files Changed Coverage Δ
frost-core/src/frost/round1.rs 87.03% <92.85%> (-2.07%) ⬇️
frost-core/src/frost/round2.rs 90.90% <100.00%> (-0.30%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dconnolly dconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

mergify bot added a commit that referenced this pull request Sep 2, 2023
@mergify mergify bot merged commit 0fb4824 into main Sep 2, 2023
15 checks passed
@mergify mergify bot deleted the cache-commitments branch September 2, 2023 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve sign() performance by caching SigningCommitments
2 participants