Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oath: add rename instruction to protocol #294

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

oath: add rename instruction to protocol #294

wants to merge 1 commit into from

Conversation

klali
Copy link
Member

@klali klali commented Apr 1, 2020

No description provided.

@klali klali requested a review from dainnilsson April 1, 2020 08:42
imakhalova
imakhalova suggested changes Apr 9, 2020
View reviewed changes
Copy link

@imakhalova imakhalova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve copy-paste mistakes.
Do you know why this adoc doesn't look good after DELETE operation on Github view? May be it requires couple spaces to understand formatting?

@klali
Copy link
Member Author

klali commented Apr 9, 2020

I don't think there's any errors in this. Please verify with a device how it behaves.

I don't know what breaks that part of the formatting, but it's unrelated to this PR. :)

imakhalova
imakhalova approved these changes Apr 9, 2020
View reviewed changes
Copy link

@imakhalova imakhalova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that works on device.
Although errors were a little bit unexpected and need to be worked around on client side.
And renaming without any change to an account also gives an error.
Providing empty name - works without error.

@nevun nevun mentioned this pull request Aug 3, 2020
Closed
StarGate01 added a commit to VivoKey/apex-totp that referenced this pull request Dec 21, 2022
@StarGate01 @klali
Add RENAME protocol specification
3d9b070 
See also: Yubico/developers.yubico.com#294

Co-authored-by: Klas Lindfors <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imakhalova imakhalova imakhalova approved these changes

@dainnilsson dainnilsson Awaiting requested review from dainnilsson

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klali @imakhalova