Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve incompatibility between standards #9

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Conversation

fredden
Copy link

@fredden fredden commented Mar 9, 2023

This will fix #6 while we wait for the Magento2 standard to adopt PSR-12.

Copy link
Collaborator

@leonhelmus leonhelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@leonhelmus leonhelmus requested a review from Anve94 March 9, 2023 13:30
@Anve94
Copy link
Member

Anve94 commented Mar 15, 2023

I'm not sure if we still need to exclude the FirstExpressionLine if multi-line if-statements are formatted following PSR-12 regardless, e.g.

// PSR-12:
// Expressions in parentheses MAY be split across multiple lines, where each subsequent line is indented at least once.
// When doing so, the first condition MUST be on the next line.

if (
    $firstExpression ||
    $secondExpression ||
    $thirdExpression
) {
    // Do something
}

But this is not blocking for me.

@fredden
Copy link
Author

fredden commented Mar 15, 2023

@fredden fredden merged commit 125b239 into master Mar 15, 2023
@fredden fredden deleted the psr2-vs-psr12 branch March 15, 2023 11:35
@fredden fredden removed the request for review from rutgerrademaker March 15, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Youwe/Global/Common standard conflicts with Magento Coding standards
3 participants