We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Youwe Common/Global ruleset is based on PSR-12, and Magento's https://github.com/magento/magento-coding-standard ruleset is still based on PSR2: https://github.com/magento/magento-coding-standard/blob/develop/Magento2/ruleset.xml There are conflicting rules in PSR2 and PSR12:
A code like this cannot properly formatted to be valid for both rules:
if ($qty->getSku() != $orderItem->getSku() || $qtyCount === 0 || isset($data['qtys'][$orderItem->getItemId()]) || $orderItem->getQtyRefunded() > 0 ) { continue; }
I would suggest to suppress PSR-12 rules and rely on Magento's ruleset.
UPD: Magento's coding standard seem to follow the PSR-2 rule:
if ($this->isCanceled() || $this->isPaymentReview() || $state === self::STATE_COMPLETE || $state === self::STATE_CLOSED ) { return false; }
The text was updated successfully, but these errors were encountered:
Will magento/magento-coding-standard#416 fix this?
Sorry, something went wrong.
This has been fixed in version 2.1.1
Successfully merging a pull request may close this issue.
Youwe Common/Global ruleset is based on PSR-12, and Magento's https://github.com/magento/magento-coding-standard ruleset is still based on PSR2: https://github.com/magento/magento-coding-standard/blob/develop/Magento2/ruleset.xml
There are conflicting rules in PSR2 and PSR12:
A code like this cannot properly formatted to be valid for both rules:
I would suggest to suppress PSR-12 rules and rely on Magento's ruleset.
UPD: Magento's coding standard seem to follow the PSR-2 rule:
The text was updated successfully, but these errors were encountered: