gowin: Himbaechel. Specify the chip variant. #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For GW2A-18 and GW1N-9 you need to specify the family in addition to partno. Signed-off-by: YRabbit <[email protected]>
gatecat
reviewed
Sep 16, 2023
| @@ -81,16 +81,19 @@ void GowinImpl::init_database(Arch *arch) | |||
| if (args.options.count("family")) { | |||
| family = args.options.at("family"); | |||
| } else { | |||
| bool GW2 = args.device == "GW2A-LV18PG256C8/I7"; | |||
| bool GW2 = args.device.rfind("GW2A", 0) == 0; | |||
There was a problem hiding this comment.
nitpick - why rfind and not find?
There was a problem hiding this comment.
find() with pos parameter only looks in that position or later.
rfind() with pos parameter only looks in that position or earlier.
if pos == 0 then rfind is faster?
There was a problem hiding this comment.
Right, makes sense, thanks for explaining
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For GW2A-18 and GW1N-9 you need to specify the family in addition to partno.