taskloop: Set an effectively unbounded chunk limit for subprocess stdio #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The small default of 64k might be suitable for public-facing servers to prevent DoS, but not for our usecases where we might transfer large amounts of data between processes.
jix
force-pushed
the
jix/subprocess_chunk_limit
branch
from
ec3f2bb
to
bfa2f06
Compare
jix
added a commit
to jix/sby
that referenced
this pull request
Dec 14, 2023
We were discarding that output anyway and before YosysHQ/mau#5 this could lead to the mau internal `stderr.readline()` failing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The small default of 64k might be suitable for public-facing servers to prevent DoS, but not for our usecases where we might transfer large amounts of data between processes.