Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer: update dev dependencies #365

Merged
merged 3 commits into from
Apr 6, 2024

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Apr 6, 2024

Context

  • Update dev dependencies

Summary

This PR can be summarized in the following changelog entry:

  • Update dev dependencies

Relevant technical choices:

Composer: update dev dependencies

Nearly all dev dependencies have had new releases. This commit updates the plugin to use the new versions.

For linting, the upgrade will get us preliminary PHP 8.4 support.
For CS, the upgrades will get us improved syntax support for PHP 8.3, more documentation and a range of bug fixes.

CS/check thresholds: require exact match for thresholds

This changes the implementation of the coding standards threshold check to require that both the YOASTCS_THRESHOLD_ERRORS environment variable, as well as the YOASTCS_THRESHOLD_WARNINGS environment variable match the current status exactly.

This prevents PR A fixing some issues and forgetting to update the threshold, which then would allow PR B to introduce new issues.

CS: minor clean up

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • N/A

Nearly all dev dependencies have had new releases. This commit updates the plugin to use the new versions.

For linting, the upgrade will get us preliminary PHP 8.4 support.
For CS, the upgrades will get us improved syntax support for PHP 8.3, more documentation and a range of bug fixes.
This changes the implementation of the coding standards threshold check to require that both the `YOASTCS_THRESHOLD_ERRORS` environment variable, as well as the `YOASTCS_THRESHOLD_WARNINGS` environment variable match the current status exactly.

This prevents PR A fixing some issues and forgetting to update the threshold, which then would allow PR B to introduce new issues.
@jrfnl jrfnl added this to the 4.6 milestone Apr 6, 2024
@jrfnl jrfnl changed the title Feature/composer update dev dependencies Composer: update dev dependencies Apr 6, 2024
@jrfnl jrfnl merged commit 787a2c5 into trunk Apr 6, 2024
45 checks passed
@jrfnl jrfnl deleted the feature/composer-update-dev-dependencies branch April 6, 2024 03:50
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8578510842

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 50.122%

Totals Coverage Status
Change from base Build 8391281769: -0.02%
Covered Lines: 1236
Relevant Lines: 2466

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants