Various small bug fixes #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6985579179
💛 - Coveralls |
The `Column::quick_edit_remove_original()` method only expects one parameter, so no need to ask WP for 2.
The `wp_nonce_field()` function by default _displays_ the field. This means that, as things were, the nonce field would be echo'd out when the function was called + would add a `1` to the `$html` string being created. The resulting `$html` string would not contain the nonce field and the nonce field would not be between the `<form>` tags. Fixed by setting the `$display` parameter to `false`. Ref: https://developer.wordpress.org/reference/functions/wp_nonce_field/
The `explode()` function will always return an array, so strict comparing the return value with an empty string will never result in a passing condition. Ref: https://www.php.net/manual/en/function.explode.php
jrfnl
force-pushed
the
JRF/various-small-bug-fixes
branch
from
fbca20c
to
4bfa2e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Column::register_hooks(): bug fix
The
Column::quick_edit_remove_original()method only expects one parameter, so no need to ask WP for 2.Newsletter::newsletter_signup_form(): bug fix
The
wp_nonce_field()function by default displays the field.This means that, as things were, the nonce field would be echo'd out when the function was called + would add a
1to the$htmlstring being created.The resulting
$htmlstring would not contain the nonce field and the nonce field would not be between the<form>tags.Fixed by setting the
$displayparameter tofalse.Ref: https://developer.wordpress.org/reference/functions/wp_nonce_field/
QA: remove redundant code
The
explode()function will always return an array, so strict comparing the return value with an empty string will never result in a passing condition.Ref: https://www.php.net/manual/en/function.explode.php
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Displaytab, sectionShow original item, enableIn a column in the Post listand saveDelete reference to original item. The original item this was copied from is: <title of the original post>Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Documentation
Quality assurance
Innovation
innovationlabel and noted the work hours.Fixes #