This repository has been archived by the owner on Sep 5, 2018. It is now read-only.
handle <noscript> as a RAWTEXT element #139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@neraliu , please give it a quick review. Thanks. |
|
this implementation is quite tricky, right now, the filtering rules for both RAW_TEXT and DATA are the same? we need to doc it. the assumption of enabling js in the browser side makes sense to me, as it is the criteria for xss. @yukinying, please have another eye on this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See bullet item 4 in http://www.w3.org/TR/html/syntax.html#concept-frag-parse-context
As we assume scripting is always enabled (otherwise, no script nor XSS),
<noscript>tag should be handled as RAWTEXT. The filter NOT_HANDLE is equiv. to the default handlebars filter.