[WIP][TEST] Mat mul whole array implementation using tiler helper tools #1924
+8,528
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
hunhoffe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes to mat mul whole array in #1870 did not change implementation of the design at all, they just added some hooks to help with visualization.
The implementation changes in this PR actually use the
TensorTiler2Dto generate offsets/sizes/strides in a new copy of the mat mul whole array design.This is useful for comparing how the code looks in each approach, but also the B tiles produced by the tiler are functionally equivalent to the B tiles produced by the original design, but the sizes/strides are different. I plan to use this branch to benchmark if the difference results in any performance changes between the two implementations.
I don't think this will be suitable for merge as-is because it may make the CI take too long to run multiple tests on both versions. However, I want to run CI tests to check my implementation so I'm creating a PR.