Update objectfifo lock analysis #1864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndraBisca
requested review from
stephenneuendorffer and
fifield
as code owners
Coverage ReportCreated: 2024-10-22 15:37Click here for information about interpreting this report.
Generated by llvm-cov -- llvm version 14.0.0 |
jgmelber
approved these changes
Oct 22, 2024
Do you have a test for this case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the lock analysis in
AIEObjectFifoStatefulTransform.cppwith a walk instead of getOps asAIE_LockOpsmight be created in a DMA region and, without this change, wouldn't be accounted for.