Remove extra peano #1855
Merged
Remove extra peano #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fifield
force-pushed
the
no_extra_peano
branch
from
bb4dde7
to
78edb18
Compare
jgmelber
approved these changes
Oct 18, 2024
fifield
force-pushed
the
no_extra_peano
branch
from
78edb18
to
c93a7ef
Compare
fifield
force-pushed
the
no_extra_peano
branch
from
c93a7ef
to
8dbb9ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove redundant and potentially harmful
--peanoPEANO_INSTALL_DIRmakewithoutPEANO_INSTALL_DIRdefined, but it should succeed because the fallback default whenPEANO_INSTALL_DIRis not defined is to use the peano path discovered by cmake, which I happen to have configured correctly.also there are tabs in the Makefiles (which could be fixed in a follow up PR).