Remaining Programming Examples to Peano #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peano needs the shift amount in the call to `shift_bytes` to be unsigned, otherwise the call is ambiguous.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Coverage ReportCreated: 2024-10-18 23:49Click here for information about interpreting this report.
Generated by llvm-cov -- llvm version 14.0.0 |
stephenneuendorffer
approved these changes
Oct 18, 2024
keryell
reviewed
Oct 19, 2024
| v16int32 fifth = add(fourth, fourth_shift); | ||
| int32_t last = extract_elem(fifth, 0); | ||
| int32_t last = extract_elem(fifth, 0U); |
There was a problem hiding this comment.
The API looks painful to use.
@jorgeb So, isn't it a problem with shift_bytes definition at the first place to forbid signed integers?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #1847