-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DesignTools.deletePblock()]: utility to delete a pblock #1020
Open
Licheng-Guo
wants to merge
1
commit into
Xilinx:master
Choose a base branch
from
rapidstream-da:delete_pblock
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4197,4 +4197,56 @@ public static void updatePinsIsRouted(Design design) { | |
updatePinsIsRouted(net); | ||
} | ||
} | ||
|
||
/** | ||
* (Untested) Remove the speicifed pblock from the XDC constraints of the design. | ||
* | ||
* This utility will iterate through the lines of the XDC constraints and | ||
* remove any lines that contain the specified pblock name and any pblock-related | ||
* commands. The commands that are considered pblock-related are: | ||
* - add_cells_to_pblock | ||
* - create_pblock | ||
* - get_pblocks | ||
* - resize_pblock | ||
* | ||
* This utility is only tested on Vivado-maintained XDC constraints. | ||
* | ||
* @param design The design to remove the pblock from. | ||
* @param pblockName The name of the pblock to remove. | ||
*/ | ||
public static void deletePblock(Design design, String pblockName) { | ||
List<String> pblockCommands = Arrays.asList( | ||
"add_cells_to_pblock", | ||
"create_pblock", | ||
"get_pblocks", | ||
"resize_pblock" | ||
); | ||
|
||
boolean foundPblock = false; // Flag to track if any matching pblock is found | ||
|
||
for (ConstraintGroup cg : ConstraintGroup.values()) { | ||
// Get the current constraints for the constraint group | ||
List<String> updatedConstraints = new ArrayList<>(); | ||
|
||
// Check if the line contains any pblock-related command and the pblockName | ||
for (String line : design.getXDCConstraints(cg)) { | ||
boolean containsPblockCommand = pblockCommands.stream().anyMatch(line::contains); | ||
boolean containsPblockName = line.contains(pblockName); | ||
Comment on lines
+4233
to
+4234
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Using
Now the robustness of this is certainly limited by RapidWright not having a XDC parser, but I would still prefer to see some stricter matching, perhaps using regex. |
||
|
||
if (containsPblockCommand && containsPblockName) { | ||
foundPblock = true; | ||
continue; | ||
} | ||
|
||
updatedConstraints.add(line); | ||
} | ||
|
||
// Update the constraints for the constraint group | ||
design.setXDCConstraints(updatedConstraints, cg); | ||
} | ||
|
||
if (!foundPblock) { | ||
System.out.println("WARNING: No such pblock '" + pblockName + "' found in the design."); | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest calling it something more clear: