Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update the default signing algorithm to ed25519 #2658

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

update the default signing algorithm to ed25519 #2658

wants to merge 12 commits into from

Commits on Mar 7, 2024

  1. update the default signing algorithm to ed25519. This causes breakage… 

    … in downstream classes like Account
    @ckeshava
    ckeshava committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    2126ad8 View commit details
    Browse the repository at this point in the history

  2. update HISTORY file

    @ckeshava
    ckeshava committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    f2c68dd View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. include trouble shooting steps: broken dependencies

    @ckeshava
    ckeshava committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    5260525 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2024

  1. update Wallet.fromMnemonic and Wallet.fromRFC1751Mnemonic to use ed25… 

    …519 as the default signing algorithm
    @ckeshava
    ckeshava committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    0a20edf View commit details
    Browse the repository at this point in the history

  2. - add unit tests for Wallet.generateSeed() with secp256k1 signing alg… 

    …orithm

- explicitly state the algorithm used with generateSeed(), instead of relying on the defaults
    @ckeshava
    ckeshava committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    a15c7c7 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. include algorithm data member in the secret-numbers/Account class

    @ckeshava
    ckeshava committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    a234fa9 View commit details
    Browse the repository at this point in the history

  2. fix lint error

    @ckeshava
    ckeshava committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    3156306 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. import Algorithm type from ripple-keypairs module

    @ckeshava
    ckeshava committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    c25d871 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Merge branch 'main' into defaultSigningAlg

    @ckeshava
    ckeshava authored Apr 8, 2024
    Configuration menu
    Copy the full SHA
    9d4cec5 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. fic lint errors: use an import alias

    @ckeshava
    ckeshava committed May 8, 2024
    Configuration menu
    Copy the full SHA
    82e5c08 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into defaultSigningAlg

    @ckeshava
    ckeshava authored May 8, 2024
    Configuration menu
    Copy the full SHA
    d094afc View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Merge branch 'main' into defaultSigningAlg

    @justinr1234
    justinr1234 authored Jul 9, 2024
    Configuration menu
    Copy the full SHA
    787ff55 View commit details
    Browse the repository at this point in the history