Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert role into collection #9

Merged
merged 12 commits into from
Jan 15, 2024

Conversation

l00ptr
Copy link
Contributor

@l00ptr l00ptr commented Feb 15, 2022

We move the role files under the roles folder and we also adapt the
molecule default scenario and the documentation. It's the first step before adding some plugins to manipulate the config through the LemonLDAP::NG API.

galaxy.yml Show resolved Hide resolved
Julian Vanden Broeck added 4 commits November 24, 2023 20:14
We remove .github action specific stuff to run our molecule scenario
in CI with different distrib and let molecule do the job
@l00ptr l00ptr force-pushed the transform-role-into-collection branch from 17978b5 to 7ea96ad Compare November 24, 2023 23:16
@l00ptr l00ptr requested a review from maxbes December 11, 2023 10:10
@l00ptr l00ptr force-pushed the transform-role-into-collection branch from 6580fc8 to a004006 Compare December 12, 2023 08:21
@l00ptr
Copy link
Contributor Author

l00ptr commented Dec 27, 2023

Any feedback for this (long standing) MR ?

@maxbes
Copy link
Contributor

maxbes commented Jan 2, 2024

@coudot looks good to me

@l00ptr
Copy link
Contributor Author

l00ptr commented Jan 12, 2024

I will have some free time to work on some improvement / maintenance on this collection the 2 next weeks. I will create a new branch starting from this unmerged one.

@coudot coudot merged commit f9a93a2 into Worteks:master Jan 15, 2024
2 checks passed
@coudot
Copy link
Member

coudot commented Jan 15, 2024

Hello @l00ptr

following review from @maxbes I merged this PR. You can start a new one from master branch if you want.

Thanks again for your contribution.

@l00ptr
Copy link
Contributor Author

l00ptr commented Jan 15, 2024

@coudot great thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants