Add way to configure vhost #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 26, 2024 11:12
We add a new Ansible module to handle VHost configuration on LemonLDAP::NG through the LLNG CLI. Currently we use the CLI because the manager API don't allow to manipulate VHost configuration. Adding new item to menu can probably done with the REST API, we will support that later on follow up commit.
We don't support the vhost role/module for rockylinux8 because python is too old and we don't want to lose some energy on it.
We add a role to configure a list of vhosts on LemonLDAP::NG with our newly added module. Currently we only call LemonLDAP CLI to configure each vhost with a basic subset of parameters. We will extend it with more args after validating that approach.
We add gpg into our Docker image (and benefit from the cache effect) instead of running molecule prepare step to install that. This only concern the Debian image, because it's already available on RockyLinux base image.
l00ptr
force-pushed
the
add-way-to-configure-vhost
branch
from
ef60b4c
to
db0faf9
Compare
|
Let's close this MR... i will recreate a new oneafter adding a basic role for vhost configuration! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first basic (proof of concept) implementation of vhost creation and configuration on LemonLDAP with a dedicated module. I would like to discuss that approach and now if it's useful or if it's a good direction. Please let me know if i should continue on this collection or if you have any idea how to implement that.
Best regards,
J.