Fix: Import & Export from Github causes reloading the playground even before accept this step. #1908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
reviewed
Oct 16, 2024
| import { PlaygroundDispatch } from '../../lib/state/redux/store'; | ||
| import { useDispatch } from 'react-redux'; | ||
| import { useEffect, useState } from 'react'; | ||
| import { setActiveModal } from '../../lib/state/redux/slice-ui'; | ||
|
|
||
| const query = new URLSearchParams(window.location.search); | ||
| export const isGitHubExportModalOpen = signal( | ||
| query.get('state') === 'github-export' |
There was a problem hiding this comment.
It seems like we could get rid of this signal and initialize the activeModal redux state using the github-export query parameter. This would also:
- Fix the linter warnings about useEffect relying on
isGitHubExportModalOpen.value. - Make the state transitions read nicer, e.g. just
dispatch(setActiveModal(null));instead oftoggleModal(false); closeModal(); dispatch(setActiveModal(null));.
For context – I introduced the signal way before we had the redux store and never got to remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
Issue #1902
Implementation details
Import & Export from Github causes reloading the playground even before accept this step.
I know that it is because of adding new params in the URL.
So I kept functionality to fire those modal via URL, but I also added logic to open those modals without adding params.
Testing Instructions (or ideally a Blueprint)
Also you can check, that opening on slug is still working (but with reloading on closing popup):
http://127.0.0.1:5400/website-server/?state=github-import