Blueprints: Use ? instead of / to CORS Proxy URLs
#1899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes GitDirectoryResource (introduced in #1858) relay the requests through `/cors-proxy.php?{url}` instead of `/cors-proxy.php/{url}`. This makes it compatible with the actual `cors-proxy.php` script Playground ended up shipping. ## Testing instructions None, this only works in production.
adamziel
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes GitDirectoryResource (introduced in #1858) relay the requests through
/cors-proxy.php?{url}instead of/cors-proxy.php/{url}. This makes it compatible with the actualcors-proxy.phpscript Playground ended up shipping.Testing instructions
None, this only works in production. Maybe you could run the Blueprint from #1858 and confirm in the network tools that it's actually using the
?instead of/.