-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store remote assets as zip #1527
Closed
bgrgicak
wants to merge
18
commits into
add/wp-version-caching
from
update/store-remote-assets-as-zip
Closed
Store remote assets as zip #1527
bgrgicak
wants to merge
18
commits into
add/wp-version-caching
from
update/store-remote-assets-as-zip
Commits on Jun 19, 2024
-
Update remaining localhost:5400 refs to 127.0.0.1:5400 (#1509)
## Motivation for the change, related issues There are some code and documentation references that still point to `localhost:5400` for dev even though the correct address is now `127.0.0.1:5400`. ## Implementation details This updates the plaintext references to `127.0.0.1:5400` and also updates the JSPI origintrial string to reference the correct address. I tested this update with the `jspi` branch, and the dev server running on the `jspi` branch loads in Chrome but only after this change. ## Testing Instructions (or ideally a Blueprint) - CI
Configuration menu - View commit details
-
Copy full SHA for bc0538e - Browse repository at this point
Copy the full SHA bc0538eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d9692cc - Browse repository at this point
Copy the full SHA d9692ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for f4bdc7c - Browse repository at this point
Copy the full SHA f4bdc7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ef6322d - Browse repository at this point
Copy the full SHA ef6322dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b3bb70f - Browse repository at this point
Copy the full SHA b3bb70fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b9bbfae - Browse repository at this point
Copy the full SHA b9bbfaeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 59fbd8f - Browse repository at this point
Copy the full SHA 59fbd8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a1a4fd - Browse repository at this point
Copy the full SHA 5a1a4fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a76688 - Browse repository at this point
Copy the full SHA 4a76688View commit details -
Configuration menu - View commit details
-
Copy full SHA for 331e61e - Browse repository at this point
Copy the full SHA 331e61eView commit details -
Networking: Remove CORS workarounds for WordPress.org API. (#1511)
## Motivation for the change, related issues api.WordPress.org/core/version-check now supports preflight requests, and so we can remove these header deletions that was to resolve CORS issues See #933 for where this was added. ## Testing Instructions (or ideally a Blueprint) The following blueprint should not have a CORS fetch failure in browser console. https://playground.wordpress.net/?mode=seamless#{%22preferredVersions%22:{%22php%22:%228.0%22,%22wp%22:%226.5%22},%22phpExtensionBundles%22:[%22kitchen-sink%22],%22features%22:{%22networking%22:true},%22landingPage%22:%22/wp-admin/update-core.php%22,%22steps%22:[{%22step%22:%22login%22,%22username%22:%22admin%22,%22password%22:%22password%22}]}
Configuration menu - View commit details
-
Copy full SHA for 06fd163 - Browse repository at this point
Copy the full SHA 06fd163View commit details -
Networking access: Fix wp_http_supports() to work without the kitchen…
…-sink extension bundle. (#1504) Fixes #1494 In #1048 I introduced a regression of #819, in that `wp_http_supports( [ 'ssl' ] )` no longer returned truthful without the kitchen-sink extension bundle loaded. This partially reverts #1048 by keeping the filters for Requests, but reinstating the deprecated WP_HTTP filters. It's worth noting, that this is not a direct revert, as it forces the Fetch/Dummy handlers instead of simply adding them as an option. This is to match the Requests filter behaviour. To test this, the following blueprint should land you on a plugin install page without any errors visible: https://playground.wordpress.net/#{%22phpExtensionBundles%22:[%22light%22],%22features%22:{%22networking%22:true},%22landingPage%22:%22/wp-admin/plugin-install.php%22,%22steps%22:[{%22step%22:%22login%22,%22username%22:%22admin%22,%22password%22:%22password%22}]} ``` { "phpExtensionBundles": [ "light" ], "features": { "networking": true }, "landingPage": "/wp-admin/plugin-install.php", "steps": [ { "step": "login", "username": "admin", "password": "password" } ] } ```
Configuration menu - View commit details
-
Copy full SHA for 51b498f - Browse repository at this point
Copy the full SHA 51b498fView commit details -
Remove trailing semicolon from example URL for loading playground wit…
…h network access (#1520) It can be confusing if one attempts to copypaste that line for reloading the page as the value for `networking` ends up being `yes;` ### After ![image](https://github.com/WordPress/wordpress-playground/assets/746152/65fd2087-5e85-483f-bd1c-164cebe57e91) ### Before <img width="1003" alt="image" src="https://github.com/WordPress/wordpress-playground/assets/746152/adf04f97-b7df-4ead-a2e1-52629f9b54fb"> ## Motivation for the change, related issues While showcasing Playground during WCEU, I found myself failing to install plugins after copy-pasting the proposed URL until I realized I was copying an unintended semicolon. ## Implementation details ## Testing Instructions (or ideally a Blueprint)
Configuration menu - View commit details
-
Copy full SHA for ccace6b - Browse repository at this point
Copy the full SHA ccace6bView commit details -
Configuration menu - View commit details
-
Copy full SHA for e13a27f - Browse repository at this point
Copy the full SHA e13a27fView commit details -
Remove deprecation note from shorthand steps (#1507)
Fixes - #1282 ## Implementation details remove the deprecation lines from the schema
Configuration menu - View commit details
-
Copy full SHA for 874bb5c - Browse repository at this point
Copy the full SHA 874bb5cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 40190c8 - Browse repository at this point
Copy the full SHA 40190c8View commit details
Commits on Jun 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 16a462a - Browse repository at this point
Copy the full SHA 16a462aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f885702 - Browse repository at this point
Copy the full SHA f885702View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.