-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search block styles in the style variations, option 1 #525
base: trunk
Are you sure you want to change the base?
Conversation
…olor on the input.
Preview changesYou can preview these changes by following the link below: I will update this comment with the latest preview links as you push more changes to this PR. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
I'm having issues with my testing setup and I don't see the same as your screenshot 😞 However, if that's how it looks for you, it's looking as intended. |
Yes the shadow for example is working well for me on the search block button. But I am concerned about how well the border radius on the input works with other inputs, mainly the comment form which always has a border radius of 4px. |
There is no way for the theme to remove this option, that I am aware of 🤔 Not even with PHP or JavaScript. |
I agree with this. Short term I can try to add it to this PR. I am still thinking of how we could do this for all inputs including the third party blocks as requested here: |
Yes, I saw that. It would be great if we could do it for all inputs.
I have replied with a visual suggestion for the select list. |
If we handle the comment form and the select list in separate PR's, this is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks well. I noticed that when you switch the style variation to one of these and then go back to one where the input has a rounded shape, then that doesn't take effect. For example, trying to go back to the default style.
Screen.Recording.2024-10-14.at.16.21.15.mov
How strange. My guess would be that it is the styles> blocks > block name > CSS that is not clearing / refreshing. |
Because of this bug, I don't think it is worth implementing this change. I think it might be too confusing that the style changes depending on what order you preview the theme variations in... |
Description
This PR changes the border radius of the search block button and search input field.
It also sets the border color of the search input field to accent color 6, the color with the opacity.
In one variation, it also updates the font family for the button.
With this option, the input field styles are limited to this single block, and managed in multiple theme.json files.
Screenshots
Noon, after
Dusk, after:
Testing Instructions
Add a search form.
Confirm that the style matches the expectations listed in this issue: #485
Repeat the test for all style variations