Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When checking for excluded files, use the normalized path to ensure that it works in Windows environments. #694

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

pbiron
Copy link
Contributor

@pbiron pbiron commented Oct 3, 2024

Fixes #693

Copy link

github-actions bot commented Oct 3, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: pbiron <[email protected]>
Co-authored-by: davidperezgar <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

…iles().

This probably should have been removed in WordPress#592, but was forgotten.
@pbiron
Copy link
Contributor Author

pbiron commented Oct 8, 2024

@davidperezgar can you please look at this PR before v1.2.0 ships?

@davidperezgar
Copy link
Member

I don't know for sure, we're in final stages of version.

@pbiron
Copy link
Contributor Author

pbiron commented Oct 8, 2024

the reason I would really like to get it into 1.2.0 is that it is a follow-up to #592 which will be included in 1.2.0. #592 fixed one prob for the WP_CLI command in Windows but missed another one.

@swissspidy swissspidy added this to the 1.3.0 milestone Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI: ensure --exclude-files works in Windows
3 participants