Add has_validator and has_filter method #348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @chaungoclong . Perhaps |
|
Hi @filisko , Thanks for the suggestion! I can add the has_filter method in this pull request along with has_validator. I'll get started on it. |
filisko
changed the title
filisko
changed the title
|
Added more stuff here #351 |
filisko
added a commit
that referenced
this pull request
Apr 29, 2024
* add has_validator method * add has_filter method * Add more test cases and update README.md --------- Co-authored-by: Dragon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method checks if a validator method exists for a given rule.
The reason for adding this method is to prevent exceptions from being thrown when using the
add_validatormethod with a rule that already exists. By usinghas_validator, we can ensure that a rule does not exist before adding it.Here are the key changes:
New Method: The
has_validatormethod takes a rule as a string parameter and returns a boolean value. It checks if a validator method exists for the given rule in theValidatorclass or if the rule is present in thevalidation_methodsarray.Test Cases: Test cases for both happy and unhappy paths have been included to validate the functionality of the new has_validator method.